search

trusteddomainproject / OpenARC

Open source ARC implementation
BSD 2-Clause "Simplified" License
135 stars 45 forks source link

Fix verification when key specifies hash algorithm #168

Open abeverley opened 9 months ago

abeverley commented 9 months ago

If an ARC key specifies the hash type as SHA256 (i.e. h=sha256) then OpenARC will fail to verify the signature. Whilst the presence of a particular hash type is detected, the type is not set and it defaults to sha1.

abeverley commented 9 months ago

Thanks @flowerysong I really appreciate the quick feedback. I've added a couple of additional commits - would you mind taking a look now please?

flowerysong commented 9 months ago

LGTM. I've integrated this and the other outstanding PRs that looked reasonable into the main branch at https://github.com/flowerysong/OpenARC.

I'm on vacation for the rest of the week so I don't have time to test this branch right now, but I hope to have a chance next week to set up some rudimentary CI.

abeverley commented 9 months ago

I've integrated this and the other outstanding PRs that looked reasonable into the main branch at https://github.com/flowerysong/OpenARC.

Brilliant. Just to mention (for people's general interest) that I personally have been using the openarc package in Debian Experimental. It already includes a few existing PRs, and then I've added in #168 and #167. Seems to work well.