search

trusteddomainproject / OpenARC

Open source ARC implementation
BSD 2-Clause "Simplified" License
135 stars 45 forks source link

Adding macros for wrapping around memory allocation code; fixing apparent leaks detected by these. #68

Closed ghost closed 6 years ago

ghost commented 7 years ago

I had the wrappers pointing to OPENSSL_malloc and such, but wasn't clear whether you'd like them. If you could keep using wrapper macros like these, I can always easily point them to debugging memory functions...

ghost commented 6 years ago

Hi Murray, sorry about that... I think the indent may have gotten dropped when I copied over from my build environment. Should be fixed now.

mskucherawy commented 6 years ago

Do you know how I can merge this onto a branch other than "master"? Or do you need to do a new PR? I want to start putting these on "develop".

ghost commented 6 years ago

I don't know... Let me know if you need anything from me. But, did you check out the memory leaks part? They seem worthy of bringing out.

.. Juan

On Thu, Dec 14, 2017 at 8:21 PM, Murray S. Kucherawy < notifications@github.com> wrote:

Do you know how I can merge this onto a branch other than "master"? Or do you need to do a new PR? I want to start putting these on "develop".

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/trusteddomainproject/OpenARC/pull/68#issuecomment-351885770, or mute the thread https://github.com/notifications/unsubscribe-auth/AdYqMYjgmrwzCq30kVfO0bnMRVEin4IOks5tAcmPgaJpZM4QRJjL .

kurta commented 6 years ago

On Fri, Dec 15, 2017 at 3:50 PM, Juan Altmayer Pizzorno < notifications@github.com> wrote:

I don't know... Let me know if you need anything from me. But, did you check out the memory leaks part? They seem worthy of bringing out.

.. Juan

Juan,

We have heard a non-specific report of memory leaks from the person working on implementing ARC for MessageSystem's Momentum/LUA too. If you have a patch, I'm sure they would be interested.

--Kurt

juh commented 6 years ago

Juan, for changing the branch the pull request is for, see https://help.github.com/articles/changing-the-base-branch-of-a-pull-request/

ghost commented 6 years ago

Hi Kurt, I did share my patch with Elliot... I'm just coming back from leave, so I'll reach out to him to see what's new. Thanks!

.. Juan

mskucherawy commented 6 years ago

I'll fix it myself.