trusteddomainproject / OpenDKIM

Other
97 stars 52 forks source link

Order of arrays for dkim_options() #179

Open countsudoku opened 1 year ago

countsudoku commented 1 year ago

The documentation for dkim_options() states for some array options: they should be unordered (DKIM_OPTS_OVERSIGNHDRS, DKIM_OPTS_SIGNHDRS and DKIM_OPTS_SKIPHDRS) and for others they should be ordered (DKIM_OPTS_MUSTBESIGNED, and DKIM_OPTS_REQUIREDHDRS). But the documentation does not tell us, in which order the ordered items should be. Also I did not find any reason by digging through the code, why some of those array options must have a specific order (maybe except of some performance benefit, if some header is found first, but this might depend on the input mail).

So can somebody elaborate, why some of these options should be ordered? Otherwise I suggest the ordered, unordered stuff should be removed from the documentation.