search

ts-safeql / safeql

Validate and auto-generate TypeScript types from raw SQL queries in PostgreSQL.
https://safeql.dev
MIT License
1.35k stars 22 forks source link

Added node-gyp prerequisites for Windows and other OSes #256

Closed Vishal-beep136 closed 2 months ago

Vishal-beep136 commented 3 months ago

Added prerequisites for Windows OS.

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 59dec955ccadfdeb02c71589e28b78247f796bcd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **safeql** | ⬜️ Ignored ([Inspect](https://vercel.com/newbie012s-projects/safeql/GgpAdGQ6D5gRrBmXt5Q9ScfmmDif)) | [Visit Preview](https://safeql-git-fork-vishal-beep136-patch-1-newbie012s-projects.vercel.app) | | Sep 10, 2024 9:01am |
Newbie012 commented 2 months ago

When I think about it, maybe it would be wise to mention node-gyp only for Windows, since you don't really need to do anything when using Linux/MacOS

karlhorky commented 2 months ago

you don't really need to do anything when using Linux/MacOS

This is not true - at least not for macOS:

  1. Newer macOS doesn't have Python preinstalled
  2. Xcode Command Line Tools also not pre-installed on macOS

The devel docs section of packages for Ubuntu Noble seem to indicate that GCC and make are preinstalled on Ubuntu.

But I guess macOS and Windows are going to make up the majority of users? And Linux users will be used to checking whether packages apply to their systems, I guess, so it's ok to have it documented for them?