search

tsattler / visuallocalizationbenchmark

342 stars 58 forks source link

Where are the descriptors added ? #65

Closed alexs7 closed 2 years ago

alexs7 commented 2 years ago

https://github.com/tsattler/visuallocalizationbenchmark/blob/1f8e4311e6fc41519e3d9909e14fce9a7f013732/local_feature_evaluation/modify_database_with_custom_features_and_matches.py#L79

I was looking at this code, and I can't understand how the descriptors are added ?

tsattler commented 2 years ago

The descriptors are not stored in the database. Colmap's database format only supports 128D descriptors and does not support any other lengths. We thus store the keypoints with dummy descriptors, do the matching outside of Colmap, and then import the matches for further processing.