tschaub / gulp-newer

Pass through newer source files only
https://npmjs.org/package/gulp-newer
226 stars 24 forks source link

Error with subdirectories #33

Open jdnichollsc opened 8 years ago

jdnichollsc commented 8 years ago

Origin: --- temp/ ---------- image1.png --- image2.png

Destiny: --- temp/ --- image2.png

Using gulp-clean after gulp-newer, temp folder is deleted instead of temp/image1.png

What do you think? :)

tschaub commented 8 years ago

I'm not sure I follow. Can you provide some example code and a bit more of a description about what you expect and what you get?

jdnichollsc commented 8 years ago

using gulp-foreach and console.log return temp file instead of temp/image1.png and it is incorrect, the temp directory already exist in the destiny :)

jdnichollsc commented 8 years ago

ohhh excuse me, your plugin works very nice! Tested with vinylPaths and del packages :dancers:

My example:

var destiny = "www/img/**/*";
var origin = "app/img";
gulp.task('clean-images', function () {
  return gulp.src(destiny, {read: false})
    .pipe(newer(origin))
    .pipe(vinylPaths(del));
});

Regards, Nicholls

jdnichollsc commented 8 years ago

Ohhh with more tests, this plugin works incorrect with subdirectories: --- origin ------- temp/ ----------- image1.png ----------- image2.png ------- image3.png

--- destiny ------- temp/ ----------- image1.png ------- image3.png

and vinylPaths return the following:

Paths: origin\temp Paths: origin\temp\image2.png

but the only new path is origin\temp\image2.png

jdnichollsc commented 8 years ago

What do you think about to create a new option parameter to compare without use modified date of the files and directories? (Only the path)

tschaub commented 8 years ago

@jdnichollsc thanks for the additional detail, but I still don't think you have described the problem enough for anybody to be able to reproduce it.

Please provide a complete example. Include the steps you take. Describe what you expect. Describe what you get. This will help others understand the issue you are seeing.

One nice way to set up an example is to create a repository with the minimum needed to reproduce your issue. The readme.md can describe what steps to take to see the problem.

jdnichollsc commented 8 years ago

Hi man, see my example to reproduce the issue: https://github.com/jdnichollsc/gulp-newer-issue

Thanks