search

tschoffelen / react-native-email-link

📭 Open an email client from React Native (for 'magic link' type functionality).
MIT License
394 stars 70 forks source link

Add placeholder index.js file #100

Closed jkimbo closed 2 years ago

jkimbo commented 2 years ago

So that the Expo plugin module resolution works. Fixes #96

After a lot of investigation the reason that the Expo plugin module resolution fails is because it can't find a index.js file. The module resolution happens in node so it doesn't pick up the .ios.js or .android.js files.

jkimbo commented 2 years ago

@tschoffelen Not sure to be honest. React Native should always prefer the .android and .ios files so this file would only be imported in a node context and since this library doesn't make sense in a node context I think it's fine to be empty.

fermmm commented 2 years ago

Can you please merge and release a new version? there is many people waiting for this

tschoffelen commented 2 years ago

@tschoffelen Not sure to be honest. React Native should always prefer the .android and .ios files so this file would only be imported in a node context and since this library doesn't make sense in a node context I think it's fine to be empty.

Makes sense! Thanks again!

tschoffelen commented 2 years ago

Released to NPM as react-native-email-link@1.13.0