Support RN new arch - Githubissues

tschoffelen / react-native-email-link

📭 Open an email client from React Native (for 'magic link' type functionality).

MIT License

394 stars 70 forks source link

Support RN new arch #126

Open huextrat opened 1 year ago

huextrat commented 1 year ago

This PR adds support for both new and old architecture.

This change is Android only, since only Android requires native dev for opening mail through an intent.

Suggestions / Discussions

[ ] Make naming clearer (ex: EmailPackage -> RNEmailPackage, EmailImpl -> RNEmailImpl, Email.java -> RNEmail.java)

⚠️ This change needs to be tested on several versions of RN with both architecture.

I've tested it on RN 0.72.4 with both old and new arch.

tschoffelen commented 1 year ago

Really appreciate your contribution! I haven't had time to test this yet, and might not for a while, but happy to merge this into master if you feel confident?

huextrat commented 1 year ago

It would be better if someone take a look at the changes and did at least one old arch / new arch test to make sure everything is working