Open ShiboSoftwareDev opened 1 week ago
/bounty $15
/attempt #262
with your implementation plan/claim #262
in the PR body to claim the bountyThank you for contributing to tscircuit/snippets!
Add a bounty • Share on socials
Attempt | Started (GMT+0) | Solution |
---|---|---|
🟢 @techmannih | Nov 26, 2024, 11:49:17 AM | WIP |
/attempt #262
@seveibar @ShiboSoftwareDev
I believe you want to remove the "Number of Pins" input field and ensure that readonly parameters, such as "Footprint String," are not displayed as input fields. Similarly, other parameters like "Number of Pins" (num_pins
), "Pitch" (p
), "Inner Diameter" (id
), and "Outer Diameter" (od
) should also be made readonly and not have input fields.
Please confirm if my understanding is correct, and feel free to share any suggestions you may have.
Remove number of pins because you should be able to change it from the input under 'Parameters'. Now the Parameters are sometimes readonly and sometimes are not, this depends on their zod type created in the footprinter repo, only readonly paramters should not be editable.
Thanks for responding! Sure, I got your point. I have started work on it.
@ShiboSoftwareDev please check
https://github.com/user-attachments/assets/58cb775b-3f59-4247-b2ae-a3ba25f3fa47
@techmannih as I said for the input fields under 'Parameters' only some of them are readonly. For example: only the num_pins param for this footprint is readonly(z.literal) and all the other params should be editable.
@ShiboSoftwareDev pease check, Now the num_pins behaves like the other parameters and it is not editable.
https://github.com/user-attachments/assets/bcb484e7-c892-41a3-bba1-7cbc3e4333e1
@ShiboSoftwareDev pease check, Now the num_pins behaves like the other parameters and it is not editable.
20241127125057.mp4
that's not what I said. some paramters are readonly and some are not; you'd know from their type definition. look at the old 'Number of Pins' input field to know how to handle num_pins because it is a special case, regardless of whether it is readonly or not. If you find it difficult to understand the terminology I'm using send my comments to chatgpt, give it some context and ask it to explain in simpler terms.