Closed benjeffery closed 3 weeks ago
These screenshots are automatically updated as the PR changes.
Totals | |
---|---|
Change from base Build 11702423404: | 0.1% |
Covered Lines: | 790 |
Relevant Lines: | 866 |
Lgtm. What's the time difference roughly?
120s before, about 4s now for a 40k sample TS with 4M mutations.
Boom, nice job!
Whilst working on other things and testing with a large TS I noticed that we are objectifying all the mutations several times. This means for a large TS start up can take way too long. I've reworked the loading code to not use the tskit row objects. Hopefully this is a good compromise. I've also added metadata to the table views.