tstaerk / mediasyntax

Mediasyntax is a plugin for Dokuwiki that enables Mediawiki syntax.
http://www.staerk.de/thorsten/Mediasyntax
GNU General Public License v2.0
10 stars 6 forks source link

Header.php causes section_edit warning messages #5

Closed lastwednesday closed 13 years ago

lastwednesday commented 13 years ago

I just updated this plugin today and remembered a fix I had applied before.

With this plugin enabled I have always run into several instances of this warning message showing up at the beginning of each page in the wiki:

_Warning: call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, 'Doku_Renderer_metadata::sectionedit' was given in //inc/parserutils.php on line 464

Based on this discussion: https://github.com/dokufreaks/plugin-creole/issues/4 it looks to be from deprecated code in syntax/header.php and the errors stop (and no impact to functionality appears on my install at least) if I simply remove that entire code block:

57,62c57,62
<       $handler->_addCall('section_edit', array(
<         $handler->status['section_edit_start'],
<         $pos-1,
<         $handler->status['section_edit_level'],
<         $handler->status['section_edit_title']
<         ), $pos);

---
>       //$handler->_addCall('section_edit', array(
>       //  $handler->status['section_edit_start'],
>       //  $pos-1,
>       //  $handler->status['section_edit_level'],
>       //  $handler->status['section_edit_title']
>       //  ), $pos);
[1]    9450 exit 1     diff header.php.orig header.php
lastwednesday commented 13 years ago

This is a duplicate of Issue #4 . Not sure why I still have it since I just downloaded the latest tar, but I git pulled this time instead and it is updated now.