What is calling plugins? - Githubissues

tsyesika / MegBot

IRC bot with plugins to make it easily extendable

http://megworld.co.uk

GNU General Public License v3.0

15 stars 3 forks source link

What is calling plugins? #83

Open moggers87 opened 6 years ago

moggers87 commented 6 years ago

This core plugin has at least 3 ways it can call event handlers from plugins:

connection.hooker.hook(connection, info) which is labelled as "old system"
connection.handler.event(event) which is labelled as "new events/hook system"
connection.core["Coreexecutor"].main(connection, info, info.plugin_name) which is labelled as new or old
- but plugins are run in threads and it appears to be the only place where that is so

This mess needs to be cleaned up and we should use one system for everything.

moggers87 commented 6 years ago

@xray7224 choose one and I can convert everything to use that ☺