search

tterrag1098 / Registrate

Your mod's best friend - keep your registry objects simple and organized
Mozilla Public License 2.0
114 stars 32 forks source link

Allow registration under a different namespace than the modid #35

Closed Rover656 closed 2 years ago

Rover656 commented 3 years ago

Allows you to register objects in a specific domain from another modid.

Was done pretty quickly, lemme know if anything needs changed 😄

tterrag1098 commented 3 years ago

This needs better javadocs, as well as a better explanation of the purpose. What is the distinction between "modid" and "domain" here? To me, a domain is a concept of resources/data, not registry objects. Registry objects always belong to a mod, not any random domain name.

I understand what you're trying to accomplish, but only because I have the context of the reason behind this PR. Someone reading this without that context would not be able to guess the distinction between the two.

Rover656 commented 3 years ago

Understood - I'll get onto this once I'm next available. Thanks for the review.

Rover656 commented 2 years ago

I have updated the javadocs and renamed domain to namespace to generalise the term. Should be okay for a second review :)

Rover656 commented 2 years ago

Yeah so this just isn't needed, I'm gonna close.