search

tth05 / morerefinedstorage

Continuation of RefinedStorage for 1.12 with focus on performance and new features.
MIT License
16 stars 7 forks source link

Fix freezing of server threads during autocrafts #21

Closed bigenergy closed 3 years ago

bigenergy commented 3 years ago

Fix https://github.com/tth05/morerefinedstorage/issues/19

tth05 commented 3 years ago

This won't be merged in this state. There are way too many unnecessary code style changes that have nothing to do with the actual "fix", which is just a weird workaround for an unknown problem. Just running the calculation on the main thread is not a fix.

bigenergy commented 3 years ago

Just running the calculation on the main thread is not a fix.

However, this is a fix for me.

tth05 commented 3 years ago

It's not a fix in the sense that it just works around the actual problem which might exist.

bigenergy commented 3 years ago

It's not a fix in the sense that it just works around the actual problem which might exist.

Hi, did you manage to find the source of the problem?

tth05 commented 3 years ago

It's not a fix in the sense that it just works around the actual problem which might exist.

Hi, did you manage to find the source of the problem?

Nope, never had it happen on my server or anyone else's server. Not sure how you managed to achieve that problem at all. My server has a system with billions of items in it, more than 20k items imported/exported per second and multiple huge crafting tasks being requested every second, but I've never had anything similar to this happen.