YouTube ad blocker sometimes blocks videos too

GoogleCodeExporter commented 9 years ago

Sometime, when I try to load a video from youtube, it just blocks it. I 
mean, there is no video. Only a white, empty area where the video would 
normally be. The rest of the page is loaded normally.

Every youtube videos.

AdThwart 0.8.8, Chrome 4.0.249.89 (38071), Windows 7 Home Premium 64bits

No custom filter, only the easy list and the one from France

In AdThwart Options, which "General" options are checked?
Block ads in youtube video
Disable inline text ads

Original issue reported on code.google.com by DrZoo...@gmail.com on 24 Feb 2010 at 3:18

GoogleCodeExporter commented 9 years ago

Thanks for reporting. This is probably because of the YouTube ad blocking. 
Sometimes 
the Flash video player may not re-load properly after ad parameters are 
removed. Can 
you try disabling YouTube ad blocking (in the General options)?

Original comment by ttjos...@gmail.com on 24 Feb 2010 at 4:36

Changed title: YouTube ad blocker sometimes blocks videos too

GoogleCodeExporter commented 9 years ago

Alternatively, please try making sure "Hide Flash objects while ads are 
removed" is 
checked. With this you may be able to leave YouTube ad blocking on as well.

Original comment by ttjos...@gmail.com on 24 Feb 2010 at 4:38

GoogleCodeExporter commented 9 years ago

Issue 45 has been merged into this issue.

Original comment by ttjos...@gmail.com on 25 Feb 2010 at 5:50

GoogleCodeExporter commented 9 years ago

Issue 60 has been merged into this issue.

Original comment by ttjos...@gmail.com on 7 Mar 2010 at 2:57

GoogleCodeExporter commented 9 years ago

Issue 83 has been merged into this issue.

Original comment by ttjos...@gmail.com on 11 Apr 2010 at 12:52

GoogleCodeExporter commented 9 years ago

AdThwart 0.8.14 addresses this issue - YouTube ad blocking should be more 
reliable now.

Original comment by ttjos...@gmail.com on 12 Apr 2010 at 7:15

Changed state: Started

GoogleCodeExporter commented 9 years ago

Issue 96 has been merged into this issue.

Original comment by ttjos...@gmail.com on 23 Apr 2010 at 4:06

GoogleCodeExporter commented 9 years ago

Issue 133 has been merged into this issue.

Original comment by ttjos...@gmail.com on 3 Jun 2010 at 8:13

GoogleCodeExporter commented 9 years ago

I'm also experiencing this issue with AdThwart - Version: 0.9.32 in Chrome 
5.0.375.127. Except the area where the video should be is black instead of 
white.

I'm subscribed to Easylist and AdThwart Recommended Filters.

I have all three options checked in the general options tab. I do not see the 
option for "Hide Flash objects while ads are removed"

Original comment by Deoz...@gmail.com on 25 Aug 2010 at 9:46

GoogleCodeExporter commented 9 years ago

Issue 214 has been merged into this issue.

Original comment by ttjos...@gmail.com on 27 Aug 2010 at 5:42

GoogleCodeExporter commented 9 years ago

Issue 218 has been merged into this issue.

Original comment by ttjos...@gmail.com on 3 Sep 2010 at 10:15

GoogleCodeExporter commented 9 years ago

These changes to the YouTube ad blocking code that should hopefully help this 
issue. They are in AdThwart as of version 0.9.36.

http://github.com/ttjoseph/adthwart/commit/ab25cea

Original comment by ttjos...@gmail.com on 22 Sep 2010 at 5:12

GoogleCodeExporter commented 9 years ago

I still experience this issue frequently in Incognito mode, but I now 
experience it less often in non-Incognito mode.

Original comment by nilsatwlonk@gmail.com on 6 Nov 2010 at 6:44

GoogleCodeExporter commented 9 years ago

YouTube ad blocking has been reworked. There will be a new development build on 
https://adblockplus.org/devbuilds/adblockpluschrome/ in 20 minutes, please try 
it and tell us whether it resolves the issue. Please note that the development 
build installs in parallel to the release version, the release version needs to 
be disabled.

Original comment by trev%adb...@gtempaccount.com on 9 Feb 2011 at 8:34

GoogleCodeExporter commented 9 years ago

The new development build fixes one problem, but unfortunately introduces a new
one. I'm seeing a black rectangle where the video should be. The console reads:

DOMException
code: 8
message: "NOT_FOUND_ERR: DOM Exception 8"
name: "NOT_FOUND_ERR"

Original comment by chrishan...@live.com on 14 Mar 2011 at 5:31

GoogleCodeExporter commented 9 years ago

Really, spamming every unrelated issue mentioning "YouTube" with your problem 
isn't going to help you. Why didn't you open a new issue for your problem?

Original comment by trev%adb...@gtempaccount.com on 14 Mar 2011 at 8:02

GoogleCodeExporter commented 9 years ago

Why didn't you merge the issues?

Original comment by chrishan...@live.com on 16 Mar 2011 at 12:33

GoogleCodeExporter commented 9 years ago

Since this is a duplicate of issue 359, which got closed for some reason,
let's continue it here since it's still open.

Comment by t...@adblockplus.org
>> I have doubts that your issue is related to the one reported here - but ok, 
>> it is similar enough, let's try to deal with it here. Given that I cannot 
>> reproduce your problem, it would be nice to get some additional information:
>>
>> 1) Which file name/line number is referenced in the console for this error 
>> message?
>> 2) Which particular video?
>> 3) Does it happen every time or only sometimes?
>> 4) Does it work if you disable "Block ads inside YouTube videos" in Adblock
>> Plus options (under "General")?

Comment by me.jfle...@gmail.com
>> Not got a single problem with the latest version. Also using the latest 
>> stable version of Chrome.

Comment by t...@adblockplus.org
>> Good, fixed then.
>>
>> @chrishandon: Since this issue is resolved, let's not continue here. Please 
>> create a topic under https://adblockplus.org/forum/viewforum.php?f=10 
>> (registration not required) and answer my questions there.

Comment by chrishan...@live.com
>>>> Good, fixed then.
>> No. It is not fixed.
>>
>>>> Not got a single problem with the latest version.
>> @trev: Hold on one second... Is this the kind of feedback that goes into your
>> testing metric?! You can't be serious. It took you no less than 13 hours to 
>> dump my feedback, yet I included specific details about the problem ... Oh, 
I 
>> see. Once the software is labeled as "perfect", any issues encountered 
>> thereafter are irrelevant.
>>
>>>> Given that I cannot reproduce your problem [...]
>> But I can. I'd advise your quality assurance staff to employ better 
>> techniques for testing.
>>
>>>> I have doubts that your issue is related to the one reported here [...]
>> Grey box, black box; replaced plavyer, missing plavyer; sounds the same to 
>> me. Given what I've said so far, nobody can blame you for having your doubts.
>>
>> If you don't want people reporting issues here, then why is this page still
>> accepting reports? Perhaps you should hide the issues page. And since you 
>> posted a notice about the new build, doesn't that mean this issue regarding 
>> YouTube still carries over?
>>
>> Please do not avoid the issue. You have a responsibility to handle problems
>> caused by this software.

Original comment by chrishan...@live.com on 16 Mar 2011 at 5:28

GoogleCodeExporter commented 9 years ago

FWIW, I no longer experience this issue. I don't know when it started working 
reliably, but it may have been the Feb 9 changes.

I left comment 13 about this issue happening frequently in incognito mode, but 
that is no longer the case. Unstarred. Thanks!

Chris, your problem is absolutely legitimate, and nobody is trying to shut you 
up. We're just trying to find the best place to discuss the particular issue 
that you are having. :-)

Original comment by nilsatwlonk@gmail.com on 16 Mar 2011 at 6:19

GoogleCodeExporter commented 9 years ago

trev's comments taken from issue 359:

>> Since you apparently didn't bother to read my comments: this issue *as 
>> reported* is fixed.
>> jfletch reported the issue and he also confirmed that things are working now 
>> - and that's pretty much the definition of "fixed".

Now you're saying I'm irresponsible since I "didn't read your comments"? But 
I'm 
quoting you and commenting on almost every one of your sentences. The guy 
you're 
talking about didn't say 'things are working now'. He said, "not got a single 
problem with the latest version."

>> Now *your* comments are a) off topic and b) not reproducible. Which means 
>> that you should: a) create your own issue report (and please not in this 
>> project, Adblock Plus forum is the place where issue reports should go into 
>> now) and b) answer the questions I asked. Offending me won't help your cause 
>> - I cannot fix an issue that I cannot reproduce. While your comment includes 
>> some details they are not enough to pinpoint the problem.

You shouldn't try to twist the situation you're in by making it seem as though 
your users are offensive, confused and not making any sense. It's bad because 
1) 
you're placing your reputation at risk since this discussion is viewable to the 
public 2) you may get caught using Straw Man arguments, which I'm sure you've 
unintentionally tried on me.

>> [...] the three issues you commented in all look like different issues to me,
>> I merely managed to fix all of them in the same set of changes.

Well, apparently that changeset must have been a hack because now you've got a 
new problem on your hands. Those issues your talking about have one thing in 
common: YouTube. issue 25 happens because of issue 43 which is the result of 
issue 359. They are not different. They are one issue seperated into three 
parts.

It's your responsibility to handle this problem since you've already admitted 
to 
creating the set of changes that causes this. Why not handle it here? You're 
giving yourself a way to avoid issues by asking your users to start a thread on 
a forum meant for random, open-topic discussions, where the thread may get 
buried underneath unrelated topics and eventually forgotten. You're also 
placing 
the users in positions of being attacked, ridiculed and crucified.

Please do not try to make it seem like I'm belligerent and confused. Take 
responsibility. That's all people want from you. And if you don't, then I'm 
obligated to tell people about the serious problem caused by Adblock Plus since 
I'm an honest person.

Original comment by chrishan...@live.com on 24 Mar 2011 at 2:43

GoogleCodeExporter commented 9 years ago

All of this notwithstanding, we still don't have enough information to 
reproduce the problem you report. Since I don't see the problem, I must be 
doing something different than you. Unfortunately, DOM errors don't provide 
backtraces as far as I know, so that makes it even harder. 

Again, this is no longer the right place to report bugs - the adblockplus.org 
forum really is the right place, and we do fix bugs that are reported there. At 
the very least more people will see your report and be able to contribute 
further information.

What versions of Chrome, ABPC, OS? Which exact URL? Does the black box appear 
every time or under specific conditions, or just randomly? Does reloading the 
page fix it? Are there other console error messages? Do you have any insight 
into what might be causing the problem, or a patch that fixes it?

Original comment by ttjos...@gmail.com on 24 Mar 2011 at 2:53

GoogleCodeExporter commented 9 years ago

Solucionado

-----Mensaje original----- 
From: adthwart@googlecode.com
Sent: Thursday, March 24, 2011 3:44 AM
To: gonzalofotoestudio@gmail.com
Subject: Re: Issue 43 in adthwart: YouTube ad blocker sometimes blocks 
videos too

Original comment by gonzalof...@gmail.com on 24 Mar 2011 at 7:55

GoogleCodeExporter commented 9 years ago

Solucionado

-----Mensaje original----- 
From: adthwart@googlecode.com
Sent: Thursday, March 24, 2011 3:54 AM
To: gonzalofotoestudio@gmail.com
Subject: Re: Issue 43 in adthwart: YouTube ad blocker sometimes blocks 
videos too

Original comment by gonzalof...@gmail.com on 24 Mar 2011 at 7:56

GoogleCodeExporter commented 9 years ago

I can confirm what Chris is saying.

ABPC 1.1.2
Chrome 12 Stable

Youtube videos show up as blank boxes when Adblock Plus' "Block ads inside 
YouTube videos" option is checked. It happens where there's an advertisement at 
the bottom of the video and only on http://www.youtube.com.

Problematic webpage:
http://www.youtube.com/watch?v=0Muco-mnC3g

I afraid I don't know what 'console error messages' refers to.

Original comment by elyetima...@gmail.com on 26 Mar 2011 at 12:03

GoogleCodeExporter commented 9 years ago

okay. I managed to get console opened.

Uncaught Error: NOT_FOUND_ERR: DOM Exception 8 
chrome-extension://cfhdojbkjhnklbpkdaibdccddilifddb/contentScript1.js:38
stripYouTubePlayerAds                          
chrome-extension://cfhdojbkjhnklbpkdaibdccddilifddb/contentScript1.js:38
onYouTubeBeforeLoad                            
chrome-extension://cfhdojbkjhnklbpkdaibdccddilifddb/contentScript1.js:66

Original comment by elyetima...@gmail.com on 26 Mar 2011 at 3:21

GoogleCodeExporter commented 9 years ago

Correction: Chrome 10 Stable

Original comment by elyetima...@gmail.com on 26 Mar 2011 at 3:30

GoogleCodeExporter commented 9 years ago

Do you have any other extensions or user scripts enabled?

Original comment by ttjos...@gmail.com on 26 Mar 2011 at 3:05

ttjoseph / adthwart-googlecode

YouTube ad blocker sometimes blocks videos too #43