ttscoff / mdless

MIT License
871 stars 39 forks source link

Can't change colour of text under headers #41

Open mans0954 opened 4 years ago

mans0954 commented 4 years ago

Consider the following markdown:

Before heading - this text looks fine on a white background.

# Heading 1

Here is some text - looks too pale on a white background

## Heading 2

Here is some more text - also looks too pale on a white background

Here is how it displays in Terminator on Ubuntu 18.04:

mdless

I would like to make the text under the headings darker, but cannot figure out which setting I need to change to do this. What HTML element do they correspond to?

Thanks.

ttscoff commented 4 years ago

What is your default foreground color in the terminal? Ideally it would be picking that up, though I'm unsure why the text before the first heading is being treated differently than text after...

-Brett

On 3 Jan 2020, at 5:13, Christopher Hoskin wrote:

Consider the following markdown:

Before heading - this text looks fine on a white background.

# Heading 1

Here is some text - looks too pale on a white background

## Heading 2

Here is some more text - also looks too pale on a white background

Here is how it displays in Terminator on Ubuntu 18.04:

mdless

I would like to make the text under the headings darker, but cannot figure out which setting I need to change to do this. What HTML element do they correspond to?

Thanks.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/ttscoff/mdless/issues/41

mans0954 commented 4 years ago

@ttscoff - I was using the Black on white Built-in scheme with Use colours from system theme selected and the Ambiance palette scheme. I experimented with changing the palette and found the text under the headings looked better with the Gruvbox light palette scheme. I then created a custom palette and found that the colour in the top right of the palette (see screenshot) controlled the colour of the text under the headings.

mdless

Does that help you identify why the text under headings was in a different colour from the top line text?

Thanks for your help.

ttscoff commented 4 years ago

Maybe. That first row should be the "bright" versions of the 8 colors, so it's possible that an escape code isn't getting cleared after the headlines. I'll take a look at that.

-Brett

On 9 Jan 2020, at 4:23, Christopher Hoskin wrote:

@ttscoff - I was using the Black on white Built-in scheme with Use colours from system theme selected and the Ambiance palette scheme. I experimented with changing the palette and found the text under the headings looked better with the Gruvbox light palette scheme. I then created a custom palette and found that the colour in the top right of the palette (see screenshot) controlled the colour of the text under the headings.

mdless

Does that help you identify why the text under headings was in a different colour from the top line text?

Thanks for your help.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/ttscoff/mdless/issues/41#issuecomment-572494046

mans0954 commented 4 years ago

Maybe. That first row should be the "bright" versions of the 8 colors, so it's possible that an escape code isn't getting cleared after the headlines. I'll take a look at that.

Thanks. Did you find anything?

Christopher

ttscoff commented 4 years ago

Haven't had much time to look at it in depth, but I'm not seeing the issue happen on my end with the latest version.