ttskch / select2-bootstrap4-theme

Select2 v4 theme for Bootstrap4
MIT License
435 stars 206 forks source link

[Suggestion] add a variables file, allow modifying the variables used in the scss files #51

Open WilliamStam opened 4 years ago

WilliamStam commented 4 years ago

im not a fan of the forcing of using secondary for many of the label colours etc. wouldnt it be better if you included a _variables.scss file similar to how bootstrap does it with !default? that way we can override the defaults with say $select2-theme-bootstrap4-secondary: $gray;

$select2-theme-bootstrap4-input-bg: $input-bg !default;
$select2-theme-bootstrap4-input-border-radius: $input-border-radius !default;
$select2-theme-bootstrap4-input-box-shadow: $input-box-shadow !default;
$select2-theme-bootstrap4-input-transition: $input-transition !default;
$select2-theme-bootstrap4-input-focus-border-color: $input-focus-border-color !default;
$select2-theme-bootstrap4-input-focus-box-shadow: $input-focus-box-shadow !default;
$select2-theme-bootstrap4-input-disabled-bg: $input-disabled-bg !default;

$select2-theme-bootstrap4-secondary: $secondary !default;

should be as easy as finding $ and then just prefixing them with a prefix and setting up a _variables.scss file

rodrigo-arias commented 3 years ago

Totally in favor of this approach

tagliala commented 3 years ago

I would like to do this in #67