ttskch / select2-bootstrap4-theme

Select2 v4 theme for Bootstrap4
MIT License
435 stars 206 forks source link

Improve style #64

Closed tagliala closed 3 years ago

tagliala commented 3 years ago

Contains changes (some are opinionated) for better integration with Bootstrap 4

Add stylelint

Move layout to its own partial

Allow users to customize individual components or to use just one of them (e.g., "single" and "layout" when "multiple" is not needed)

Improve single component

Improve multiple component

Improve layout partial

Fix cursor on disabled elements

Reproducible with Chrome 88 on macOS

Before

image

After

image

ttskch commented 3 years ago

@tagliala Thanks for your contribution! I think your PR is great. But I've just pushed some commits, so could you please resolve the conflicts? 🙇

tagliala commented 3 years ago

Hi @ttskch

I've rebased and I've added a fix for cursor in disabled elements

I've also add stylelint with (almost) the same configuration as bootstrap (I've included a regex to allow BEM-like selectors)

ttskch commented 3 years ago

@tagliala Thanks a lot!