search

tttapa / py-build-cmake

Modern, PEP 517 compliant build backend for creating Python packages with extensions built using CMake.
https://pypi.org/project/py-build-cmake
MIT License
45 stars 7 forks source link

Check absolute min cmake version for CLI compatibility. Fixes #6. #7

Closed cimes-isi closed 2 years ago

cimes-isi commented 2 years ago

Enforce the absolute minimum CMake version for the CLI compatibility that py-build-cmake requires.

I imagine that future compatibility checks may (1) increase the minimum required version or (2) require adding additional code that logically extends from this constraint, but a minimum version check should never be removed. In the case of (2), the additional checks can likely be considered orthogonal problems that may eventually be superseded later by future increases in the minimum version.

tttapa commented 2 years ago

Hi, sorry, I had some commits ready but I didn't push them yet:

https://github.com/tttapa/py-build-cmake/commit/c9a3950be5767d3862d43e489c60733d584a0b84#diff-72abaf20a5b0741fd7f27bcd10830e61890440d966969e8d803069e9a0d7646f

cimes-isi commented 2 years ago

OK, thanks. Closing.