tuarua / Firebase-ANE

Firebase Adobe Air Native Extension for iOS 12.2+ and Android 19+. Includes OneSignal and Google SignIn
Apache License 2.0
32 stars 5 forks source link

[Auth] Add support of Google Play Games on Android #53

Closed mrchnk closed 3 years ago

mrchnk commented 3 years ago

Add missing support of Google Play Games Authentication on Android using custom GoogleSignIn options.

mrchnk commented 3 years ago

I will rewrite that using your suggestions. Actually, I don't need both Google Sign In and Play Games Sign In at the same time, so I will keep GoogleSignIn singleton pattern.

I think breaking compatibility on apiKey should be done also. That value will be moved into settings and named properly.

mrchnk commented 3 years ago

I made my changes to the same branch.

tuarua commented 3 years ago

I made my changes to the same branch.

Thanks I will take a look. If you can just change the merge branch to tuarua:development. I tend to only merge to master when creating a release (I will incorporate your changes with next release.)

mrchnk commented 3 years ago

If you can just change the merge branch to tuarua:development

Done.