updated the subscribe button styling to match the new youtube ui

tubearchivist / browser-extension

Tube Archivist Companion for your Browser

GNU General Public License v3.0

150 stars 19 forks source link

updated the subscribe button styling to match the new youtube ui #29

Closed gautamkrishnar closed 1 year ago

gautamkrishnar commented 1 year ago

Before

After

cc: @@bbilly1

bbilly1 commented 1 year ago

Looks good. Heads up, that is also used on the video detail page, e.g. /watch?v=, that's where the adjustOwner comes into play, as otherwise our button will overlap with the YT button, especially on smaller screens.

gautamkrishnar commented 1 year ago

@bbilly1 good find 😄 fixed it.

Screenshot 2023-11-01 at 3 21 49 PM

Do you still want to keep the old code of adjustOwner that sets styles, because this new one is also looking good on small screens: Screenshot 2023-11-01 at 3 26 21 PM

bbilly1 commented 1 year ago

Nice, looks like the adjust owner thing isn't really needed any more, I remember needing it before as this would mess up the positioning with the other buttons there.

I think there is still a small problem introduced with my changes from before, trying to build links for /shorts/ urls, but I don't think that's related to your changes here.

In any case, thanks for your improvements, let's merge this and I'll look into fixing the that on my side.