Closed SamFayolle closed 1 year ago
That's on me, I modified the acceleration formula for the tides on the moon (it had an extra factor 2, which is also something I identified when benchmarking Tudat and NOE). But I forgot to modify the corresponding unit test, something that I can fix it tomorrow too. You can have a look at either Valery's or Lari's papers but I think that the factor 2 should indeed go away.
Should be fixed now :)
Thanks! Indeed, the unit test now also passes for me :) Code merged!
Thanks for adding this, this puts the estimation of tidal parameters more in line with typical practice :)
In the unit tests, there is one failure in the partials (
test_acceleration_partials/testDirectDissipationAccelerationPartial
). For the case whereuseRadialTerm = 1
andusePlanetTide = 0
, the partials w.r.t. Io's and Jupiter's position seem to be off by a factor exactly equal to 2 (analytical - numberical)/analytical=2