tudat-team / tudat

A C++ platform to perform astrodynamics and space research.
BSD 3-Clause "New" or "Revised" License
17 stars 28 forks source link

Feature/tidal quality factor #172

Closed SamFayolle closed 1 year ago

DominicDirkx commented 1 year ago

Thanks for adding this, this puts the estimation of tidal parameters more in line with typical practice :)

In the unit tests, there is one failure in the partials (test_acceleration_partials/testDirectDissipationAccelerationPartial). For the case where useRadialTerm = 1and usePlanetTide = 0, the partials w.r.t. Io's and Jupiter's position seem to be off by a factor exactly equal to 2 (analytical - numberical)/analytical=2

SamFayolle commented 1 year ago

That's on me, I modified the acceleration formula for the tides on the moon (it had an extra factor 2, which is also something I identified when benchmarking Tudat and NOE). But I forgot to modify the corresponding unit test, something that I can fix it tomorrow too. You can have a look at either Valery's or Lari's papers but I think that the factor 2 should indeed go away.

SamFayolle commented 1 year ago

Should be fixed now :)

DominicDirkx commented 1 year ago

Thanks! Indeed, the unit test now also passes for me :) Code merged!