Generate files on compile time instead of adding them to version control

Timple commented 6 years ago

This way the changes and pull requests become much more clear on what is actually changed.

MatthijsBurgh commented 5 years ago

I was able to figure out the following (From https://github.com/tue-robotics/tue_mobile_ui/blob/master/CONTRIBUTING.md and some testing).

required packages:

apt: nodejs, libgif-dev
npm: grunt-cli bower (Both for challenge_open only)

Install/build steps:

go to folder of ui
npm install (installs all deps)
npm run build (generates the 'dist')

Install/build steps (challenge_open):

go to folder of ui
npm install (installs all npm deps)
bower install (installs all bower deps)
grunt build (generate the 'dist')

I haven't figured out yet:

what should be in a install script?
how to incorporate the rest in CMake?
how to prevent rebuilding, when no changes.
how to correctly depend on robot-api. Do we build robot-api also from source? Or do we depend on the released version? But how do you develop in that way? So can you switch from released to local source? How to release robot-api?

@Rayman Is it correct what I figured out and could you help us with the remaining issues?

Timple commented 5 years ago

Another option is to compile in CI and only download the resulting files in the tue-env target

I have some code snippets that would accomplish this if anyone is interested

reinzor commented 5 years ago

Something like this in CMAKE would work:

find_program(NPM npm REQUIRED)
execute_process(COMMAND ${NPM} install WORKING_DIRECTORY ${PROJECT_SOURCE_DIR})
execute_process(COMMAND ${NPM} run build WORKING_DIRECTORY ${PROJECT_SOURCE_DIR})

reinzor commented 5 years ago

Better to switch fully to npm btw instead of using and npm and grunt and bower

Rayman commented 5 years ago

Grunt isn't used anymore. It's only npm install, npm run build

tue-robotics / tue_mobile_ui

Generate files on compile time instead of adding them to version control #29