search

tue-robotics / tue_robocup

RoboCup challenge implementations
https://github.com/orgs/tue-robotics/projects/2
41 stars 12 forks source link

Demo peter #1341

Closed PetervDooren closed 5 months ago

PetervDooren commented 5 months ago

Some suggestions based on our demo today. Fixes the following problems:

  1. reinstates wait for trigger. I find this useful for demos since the presenter can determine the tempo of the presentation. Otherwise the robot is constantly asking for validation.
  2. Fix the timeout logic for not hearing the operator. Previous implementation just continued with the loop which crashes if the sentence parameter was not initialised. Otherwise it will just redo the previous command. Now it says "oops we couldn't do it." and waits for the next trigger.
PetervDooren commented 5 months ago

@MatthijsBurgh please don't add commits to this PR. If you have suggestions for the demo please make a PR to the update_demo branch which Lotte oversees. These changes have been tested on the robot.