Update cudd.pyx - Githubissues

tulip-control / dd

Binary Decision Diagrams (BDDs) in pure Python and Cython wrappers of CUDD, Sylvan, and BuDDy

https://pypi.org/project/dd

Other

182 stars 39 forks source link

Update cudd.pyx #90

Closed SaiCharanMarrivada closed 2 months ago

SaiCharanMarrivada commented 1 year ago

I found that bdd.var('x') ^ bdd.var('y') is much faster compared to bdd.add_expr('x ^ y'). For instance, later took 14.6us while former took only 300ns.

slivingston commented 1 year ago

@SaiCharanMarrivada Can you tell me why you continue to push so many "Update (filename)" commits? Or, tell me when this is ready for review.

SaiCharanMarrivada commented 1 year ago

@slivingston Sorry, No more commits and it is ready for review. Thanks for such a nice package in python, it is very helpful for my project.

johnyf commented 11 months ago

Calling dd.cudd.BDD.apply() calls Cudd_bddXor(), dd.cudd.BDD.add_expr() also calls the parser.

slivingston commented 2 months ago

@SaiCharanMarrivada This PR needs work, in particular:

There are a bunch of little commits without clear commit messages.
A key question is not answered: "In which cases have reordering methods other than sifting been measured faster ?"
There should be more documentation or examples that demonstrate your proposed change.
A concise description for the pull request would help. (Currently it is empty.)

I am going to close the PR assuming it is abandoned, but feel free to re-open or send a new PR, considering my feedback.