Cata Pre Patch Shadow Dance Broken

tullamods / Dominos

A main actionbar replacement

https://tullamods.com/dominos

BSD 3-Clause "New" or "Revised" License

79 stars 27 forks source link

Cata Pre Patch Shadow Dance Broken #853

Closed YOLTS closed 1 month ago

YOLTS commented 2 months ago

Reporting an issue following Cata Pre-Patch: Rogue shadow dance ability no longer changes the main action bar (as it did before the pre patch). Disabling Dominos, the main action bar changes to "Action Bar 8"(as labeled in Dominos). Hoping we receive fix soon. Thanks :)

Nekura-Neko commented 2 months ago

I'm thinking this one is circa line 177 of dominos/core/barStates.lua where it version-checks for Wrath, but the call for GetSpellInfo by ID seems a bit risky given how many skills got squirreled up in the Cata release.

-- wrath shadowdance
if Addon:IsBuild('wrath') then -- Prime culprit right here!
    addState('class', 'shadowdance', '[bonusbar:2]', GetSpellInfo(51713)) --but is the spell ID still correct?

Tuller commented 2 months ago

This one was already fixed in the cata branch, which is now merged into the main release. In terms of the spell ID check - That's there to provide the name of ability in the paging section of the bar's context menu.