search

tumblr / pytumblr

A Python Tumblr API v2 Client
Apache License 2.0
723 stars 196 forks source link

Added ability to retrieve notes #133

Closed Nigel2x4 closed 5 years ago

Nigel2x4 commented 5 years ago

Added ability to retrieve a post's note information.

komapa commented 5 years ago

Thank you for the rename. Can we add also a quick unit test for the new method and we should be ready to merge here!

Nigel2x4 commented 5 years ago

Added a test and fixed the quotations. Should be good now! Thank you for your patience.

komapa commented 5 years ago

This looks great. I just want to make sure you did follow the step in the CONTRIBUTING guide before we can merge the PR: https://github.com/tumblr/pytumblr/blob/master/CONTRIBUTING.md Once that is done, we can get it in and release a new version.

komapa commented 5 years ago

@Nigel2x4 bump for signing the CLA. The CLA, contact information, and GitHub sign-in can be found here: https://yahoocla.herokuapp.com.

Nigel2x4 commented 5 years ago

I should've already had that, did it reject me?