Replace ipinfo.io with ifconfig.me

tunix / digitalocean-dyndns

Dynamic DNS using DigitalOcean's DNS Services

76 stars 30 forks source link

Replace ipinfo.io with ifconfig.me #12

Closed villor closed 3 years ago

villor commented 3 years ago

I just set this up on a new computer and saw that the IP field was empty at all times. Turns out ipinfo.io is no longer available, so I replaced it with ifconfig.me.

tunix commented 3 years ago

@villor - ifinfo.io still works for me. are you sure it's unavailable? maybe something in your network is blocking it?

maybe we can do better by trying both of them?

villor commented 3 years ago

@tunix - you are so right, it was my PiHole (DNS) blocking the requests. Now I feel stupid :man_facepalming: But yeah, trying both sounds like a good idea.

tunix commented 3 years ago

Would you amend your PR or should I do it?

villor commented 3 years ago

I updated the script to try both. Please review the code as I'm not really experienced with sh-scripting.

tunix commented 3 years ago

Hi @villor ,

Sorry for my delayed response. Thank you for your updated patch! I have a better idea for trying multiple services to fetch from one of them so I'm closing this PR and will push the updated code shortly after.