search

tunoltd / emoji-mart-native

One component to pick them all 👊🏼
https://tunoltd.github.io/emoji-mart-native
BSD 3-Clause "New" or "Revised" License
86 stars 31 forks source link

Add RN example #6

Closed pederjohnsen closed 5 years ago

ex7r3me commented 6 years ago

@pederjohnsen do you have anything in mind for the sample app? I can help with making a sample app for android

pederjohnsen commented 6 years ago

@ex7r3me I was really just thinking of doing something similar to how emoji-mart does it with this: https://missive.github.io/emoji-mart/, basically just showcasing how the actual picker looks/works.. Preferably having the source run on both iOS and android too so only one example app is needed.

ex7r3me commented 6 years ago

@pederjohnsen we can use an RN Picker component to choose the set and show the emoji picker and then the selected emoji just like the emoji-mart demo. I agree with the single source code for both iOS and Android and it shouldn't be a problem as it's react native, I think I can find a Mac and test the app on iOS too if you aren't on this issue already.

pederjohnsen commented 6 years ago

@ex7r3me sounds good, if you take it on and have any issues regarding the localImages stuff just give me a shout, can't remember if the readme explains the implementation well enough yet (think it will best to use it, as using online sources doesn't work very well) I'll be able to test on both android/iOS if required :ok_hand:

ex7r3me commented 6 years ago

@pederjohnsen nice, I take it. I need to get localImages working for another project too, so I'll check it and let you know if any help needed. thank you 👍

ex7r3me commented 6 years ago

Hey @pederjohnsen! I've made a sample app in my forked repository here, is it good to open a PR to review or you'll checkout from there? about the local images, I used emoji-data but it seems they have removed the emojione from their repository due to some licensing issues explained here. so I couldn't use the all.js file and had to do some hacky way to include all data, please let me know if there's another way. to get local images work I had to copy images from emoji-data but they have a for example npm install emoji-datasource-apple command to install a single set, we may able to use this and give paths relative to node_modules for images to make installation easier and keep example directory lighter (it has ~45MB assets folder).

pederjohnsen commented 6 years ago

Hey @ex7r3me :upside_down_face:

It'd be great if you could open a PR for review :+1:

I'll look into cleaning up the repo to not include emojione anywhere and look into using the npm packages for local images during the next few days :ok_hand: (if it works well it's a better solution to suggest in readme than what's there currently)

ex7r3me commented 6 years ago

Thanks @pederjohnsen I'd open a PR, update me about changes need to be done. I would be happy to make it better 😊 I saw the issues about the emojione and npm packages, let me know if could give any help there 👍