search

turbonomic / orm

Operator Resource Mapping
Apache License 2.0
5 stars 13 forks source link

fix build push #28

Closed tian-ma closed 1 year ago

tian-ma commented 1 year ago

After the changes here, I can run

 make REPO=docker-na.artifactory.swg-devops.com/hyc-turbo-internal-team-docker-local/turbonomic/tamer TAG=0.1 docker-buildx

image

to use the image

make REPO=docker-na.artifactory.swg-devops.com/hyc-turbo-internal-team-docker-local/turbonomic/tamer TAG=0.1 PULL_SECRET=jfrogcred deploy

kubectl config set-context --current --namespace orm-system

kubectl create secret docker-registry jfrogcred --docker-server=docker-na.artifactory.swg-devops.com --docker-username=tamer.mohamed@ibm.com --docker-password=cmUlk --docker-email=tamer.mohamed@ibm.com

kubectl delete pods -l control-plane=controller-manager
kuanf commented 1 year ago

Couldn't test it but looks good.

kuanf commented 1 year ago

@tian-ma I'm going to reject this PR to keep the build process compatible with operator sdk guidance. https://sdk.operatorframework.io/docs/building-operators/golang/quickstart/#olm-deployment

The dockerfile in master branch is updated and can build image now. The image is not part of turbonomic product, so it doesn't impact anything.

kuanf commented 1 year ago

closing it as stated in last comment