turbot / steampipe-mod-aws-compliance

Run individual controls or full compliance benchmarks for CIS, PCI, NIST, HIPAA and more across all of your AWS accounts using Powerpipe and Steampipe.
https://hub.steampipe.io/mods/turbot/aws_compliance
Apache License 2.0
372 stars 63 forks source link

Column ordering in .csv output is inconsistent #351

Closed ciaran-finnegan closed 2 years ago

ciaran-finnegan commented 2 years ago

Describe the bug The column ordering in .csv output is inconsistent for different queries, account_id sometimes precedes region and vice versa.

Steampipe version (steampipe -v) Example: 0.14.0-alpha.0

Plugin version (steampipe plugin list) Example: 0.52.0

To reproduce Steps to reproduce the behavior (please include relevant code and/or commands). Run the following checks:

Note the headers in .csv output are ordered as follows (account_id precedes region): group_id,title,description,control_id,control_title,control_description,reason,resource,status,account_id,region,audit_manager_control_tower,hipaa,nist_csf,service,soc_2

Expected behavior Expect headers in .csv output to be ordered as follows (region precedes account_id): group_id,title,description,control_id,control_title,control_description,reason,resource,status,region,account_id,hipaa,nist_800_53_rev_4,nist_csf,service

Additional context Expected behaviour is based on the observed .csv column ordering for the following control checks:

misraved commented 2 years ago

Hello @slartibastfast, Welcome to Steampipe 👍 !! Great to see that you are using the AWS Compliance mod in such detail !!!

The issue that you have mentioned has more to do with the core Steampipe CLI and this is already being tracked/investigated by @kaidaguerre

https://steampipe.slack.com/archives/C01UECB59A7/p1647893391363249

Please feel free to add your thoughts and experiences to the above thread 👍

cbruno10 commented 2 years ago

@slartibastfast Please also see the relevant issue in the Steampipe repo, https://github.com/turbot/steampipe/issues/1715, for more updates.

ciaran-finnegan commented 2 years ago

Thanks for the quick reply!

ciaran-finnegan commented 2 years ago

Hi @misraved & @cbruno10, thanks so much, can confirm that column ordering appears to be consistent in 0.14.0-alpha.3, keep up the great work, loving Steampipe!

misraved commented 2 years ago

Thanks @slartibastfast for the confirmation !!

Great to know that you love Steampipe 👍 . Please do let us know in case you run into issues or have questions n general.