Open ritin0204 opened 3 weeks ago
Hi, @ritin0204, thanks for the contribution! 🎉
Could you please take a look at the following points?
Thanks!
HI, @ParthaI,
Sorry for late response,
can you provide me some resources to set it up and test it locally? while developing the plugin.
As the change was just to add support for fine grained token same as other tokens so i haven't tested it with run, however the APIs seems to be working fine used here.
Hey @ritin0204, sorry for the brevity of my previous review comment, as it may not have provided enough clarity to fully explain the feedback.
can you provide me some resources to set it up and test it locally?
Could you please clarify what specific information or resources you need from us?
In my previous comment, I intended to highlight the following:
connect()
for the REST API (v3) client.connectV4()
for the GraphQL API (v4) client.v3
client and not v4
.
github_search_user
, github_branch
, github_tag
, etc... that rely on the v4
client will encounter errors with these changes if the fine-grained access token is used to query the tables.As the change was just to add support for fine grained token same as other tokens so i haven't tested it with run, however the APIs seems to be working fine used here.
Thanks!
docs: https://github.blog/security/application-security/introducing-fine-grained-personal-access-tokens-for-github/