turbot / steampipe

Zero-ETL, infinite possibilities. Live query APIs, code & more with SQL. No DB required.
https://steampipe.io
GNU Affero General Public License v3.0
6.67k stars 262 forks source link

Uninstalling a plugin don't remove the rate-limiter config from the table `steampipe_plugin_limiter` #4255

Open ParthaI opened 2 months ago

ParthaI commented 2 months ago

Describe the bug After installing a plugin and configuring the rate limiter in the plugin.go file (refer to https://github.com/turbot/steampipe-plugin-aws/blob/main/aws/plugin.go#L51-L76), the corresponding rows are added to the steampipe_plugin_limiter table. However, these rows remain in the table even after the plugin is uninstalled.

Steampipe version (steampipe -v) Example: v0.22.2

To reproduce To replicate the issue, follow these steps using the existing PR branch (add-rate-limiter-config) in the GCP plugin:

Expected behavior Uninstalling the plugin should remove any related rate limiter configurations from the table.

Additional context Add any other context about the problem here.

github-actions[bot] commented 1 week ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.