search

turnermm / news

Dokuwiki plugin for creating external newsfeeds for feed readers
http://www.dokuwiki.org/plugin:news
0 stars 6 forks source link

PHP error in Non-multi user mode #7

Closed ssahara closed 8 years ago

ssahara commented 10 years ago

Hi, I have just tested the news plugin 2014-05-28 with the DokuWiki Release 2014-05-05a "Ponder Stibbons". I could generate a feed under multi user mode with ~~NEWSFEED:department_1~~. However, most simple trial with ~~NEWSFEED~~ was failed to generate any feed. There is a PHP error found:

[16-Sep-2014 20:31:20 Asia/Tokyo] PHP Warning:  array_shift() expects parameter 1 
to be array, null given in /path/to/dokuwiki/lib/plugins/news/scripts/feedData.php 
on line 158

I appreciate it if you could fix the error. Satoshi

turnermm commented 10 years ago

This should be fixed in the latest update.

ssahara commented 10 years ago

Hi, turnermm The news plugin release 2014-09-16 worked fine. Thanks for your quick update.

BTW, I feel to make the plugin code tidy, ie. removing unnecessary white spaces, better indentation etc. And I am planning to add Japanese language files. Do you mind if I will make push request with better coding style? Satoshi

turnermm commented 10 years ago

Do you mind if I will make push request with better coding style?

I appreciate the offer, but I prefer to leave things as they are. Because I use a diff system for detecting changes between my development branch and github's master, I can easily insert changes into the master. If you did what you suggest I would have to update the local git and re-test the plugin. Since I am responsible for over 20 plugins/templates involving thousands of lines of code, to do this with all of my code would require more work than I can begin to think about. But, again, thanks for your offer.

(Spacing problems occurred because of changes to the configuration files for my copy of Notepad++ which happened during updates and which are not visible in Notepad++.)