search

turnitin / moodle-plagiarism_turnitin

Turnitin Plagiarism plugin for Moodle
http://www.turnitin.com
GNU General Public License v3.0
49 stars 70 forks source link

Moodle Plugin CI, and Moodle coding style #728

Open lucaboesch opened 4 months ago

lucaboesch commented 4 months ago

In these commits, I wanted to prove that the plagiarism_turnitin plugin could well be rewritten/reformatted to adhere to Moodle coding guidelines. The submitted did not completely fix PHPUnit and Behat tests, though.

Thanks for taking into consideration. If desired, I can also divide into smaller pieces, of course.

jack-tii commented 3 months ago

Thanks very much for this PR, we should definitely be following the Moodle style guides. We are currently having internal discussions about how best to add Github workflows to our plugins as described in https://moodlehq.github.io/moodle-plugin-ci/ Merging this would therefore have to wait until after our next TT release, which is currently planned for August 1st. I will keep you updated regarding our decisions around this, as this is a feature I would love to have.

lucaboesch commented 3 months ago

I can understand very well. Please refer to #731 where the same code lies but with the omission of Github workflows.