search

turnitin / moodle-plagiarism_turnitinsim

7 stars 9 forks source link

TII Integrity plugin breaks amending default activity completion #123

Closed chris-pratt-olms closed 4 months ago

chris-pratt-olms commented 3 years ago

Plugin version: v1.2 2021030901

Going to a course > Edit course completion > Select 'Default Activity Completion' > Pick an assignment activity and click 'Edit'

This error appears:

Coding error detected, it must be fixed by a programmer: JavaScript collection has already been started.

More information about this error

×Debug info: Error code: codingerror ×Stack trace: line 900 of /lib/pagelib.php: coding_exception thrown line 86 of /completion/classes/defaultedit_form.php: call to moodle_page->start_collecting_javascript_requirements() line 109 of /completion/classes/defaultedit_form.php: call to core_completion_defaultedit_form->get_module_form() line 214 of /lib/formslib.php: call to core_completion_defaultedit_form->definition() line 56 of /course/editdefaultcompletion.php: call to moodleform->__construct()

Turning off these allows the page to work normally:

image

dwinn commented 3 years ago

Hi @chris-pratt-olms ,

Thank you for pointing out this bug. We have been able to reproduce this locally. We are preparing a release in the very near future and have managed to put a fix in for this.

carl-hostrander commented 4 months ago

Thank you for reporting this. Because the latest version of the plagiarism plugin is supported for versions of Moodle 4.1 and higher, I am closing this ticket. However, if you find this issue is occurring with the latest version of the plugin in any of the supported Moodle versions, please create a new ticket and we will address it.

acquaalta commented 3 months ago

Hi @carl-hostrander, Please see that issue of the sibling plugin: https://github.com/turnitin/moodle-plagiarism_turnitin/issues/685 The moodle-plagiarism_turnitinsim also suffers from that issue in Moodle 4.3 Since maybe the 4.3 issue is related to this issue, I'm commenting here.

The error/exception in the "Site administration --> Courses --> Default settings --> Default activity completion" page in Moodle 4.3 exists at least with the following versions combination: Moodle version: 4.3.2 PHP version: 8.2.13 Plugin version: plagiarism_turnitinsim v1.2 (2023062901)