search

turquoiseowl / i18n

Smart internationalization for ASP.NET
Other
556 stars 155 forks source link

Fixed bug described in issue #351 #398

Closed vhatuncev closed 4 years ago

vhatuncev commented 4 years ago

351

Changed condition to mark position as a start of new entry. Before only # character was entries delimiter. @turquoiseowl do you have any PO files examples which I can test locally after these changes? Also, what do you think about code refactoring for POTranslationRepository.ParseTranslationFile method? I see benefits from doing so as ability to unit test file parsing operations and create separate class for it like POFileParser or something like that. Current ParseTranslationFile method is big and can be reduced.

turquoiseowl commented 4 years ago

Thanks for this. My apologies for the delay - I wasn't getting github emails. I suggest we tests via a prerelease release.

vhatuncev commented 4 years ago

@turquoiseowl ok, what of the process for prerelease and how I can help?