search

tursodatabase / libsql

libSQL is a fork of SQLite that is both Open Source, and Open Contributions.
https://turso.tech/libsql
MIT License
9.54k stars 252 forks source link

Implement FromValue trait for byte arrays. #1463

Closed ignatz closed 3 months ago

ignatz commented 3 months ago

(small nit on the side and I feel bad for commenting on formatting, but could you check in a .rustfmt.toml that matches your style? I accidentally ran fmt on the repo by reflex... :hide: but I would also feel more confident in the consistency of my formatting if I could leave it to the robots)

MarinPostma commented 3 months ago

hey, we use stock rustfmt, and the CI shouldn't pass without rustfmt, so go ahead :)

could you please add a small unit test somewhere, please? otherwise lgtm :)

Thanks!

ignatz commented 3 months ago

hey, we use stock rustfmt, and the CI shouldn't pass without rustfmt, so go ahead :)

Apologies and glad to hear I was wrong. I was suffering from a case of nested workspace syndrome :hide:

could you please add a small unit test somewhere, please? otherwise lgtm :)

:+1: I didn't find a fitting place, so I added a new one. Happy to move it around.

Thanks

MarinPostma commented 3 months ago

thanks!