Make libsql-ffi's build more friendly to sandboxed environments.

tursodatabase / libsql

libSQL is a fork of SQLite that is both Open Source, and Open Contributions.

https://turso.tech/libsql

MIT License

9.54k stars 252 forks source link

Make libsql-ffi's build more friendly to sandboxed environments. #1478

Closed levydsa closed 3 months ago

levydsa commented 3 months ago

Fixes https://github.com/ipetkov/crane/issues/644. I wonder why it copies the bindgen.rs file so many times to the same location.

Also, two symlinks were causing trouble when copying the source to the nix store, they are currently pointing to nothing. So I just copied them from somewhere else in the project.

penberg commented 3 months ago

@LucioFranco @levydsa We build on Windows all the time... For some reason, this does not seem to break Windows build, but now I am curious to understand why that is. Clearly we can't just run a UNIX command like that from build.rs and be portable.

levydsa commented 3 months ago

In this same build file there is a call to make and shell script configure. I think some coreutils are available via mingw, but I'm not sure. I'll try to find a more cross platform solution.