Use `max_frame_no` for transaction reads and writes - Githubissues

tursodatabase / libsql

libSQL is a fork of SQLite that is both Open Source, and Open Contributions.

https://turso.tech/libsql

MIT License

9.54k stars 252 forks source link

Use `max_frame_no` for transaction reads and writes #1507

Closed avinassh closed 3 months ago

avinassh commented 3 months ago

Storage server now uses max_frame_no from the txn to read frames It will make sure to not read any frames beyond the max_frame_no of the transaction. This fixes the bug in the isolation level.
Storage server now checks max_frame_no before inserting. If it has changed meanwhile, then it rejects the insertion request.

This lets us have multiple (non concurrent) writers or even multiple logical primary instances.

Minor changes:

Improved the way we handle keys in Foundation DB
Added basic tonic error handling