handler, s3store: Serve GET requests directly from S3

tus / tusd

Reference server implementation in Go of tus: the open protocol for resumable file uploads

https://tus.github.io/tusd

MIT License

3.09k stars 480 forks source link

handler, s3store: Serve GET requests directly from S3 #1208

Open pcfreak30 opened 1 month ago

pcfreak30 commented 1 month ago

Add ContentServerDataStore interface
Update handlers to use ContentServerDataStore when available
Implement range request handling for s3upload
Add tests for new ContentServerDataStore functionality
Update Go version to 1.22.1

Closes #1064

pcfreak30 commented 1 month ago

Please note I tried to avoid changing the go version, but go mod tidy seems to automatically do it.

This is a draft to get feedback.

@Acconut

pcfreak30 commented 1 month ago

@Acconut changes have been made. kudos.

pcfreak30 commented 4 days ago

@Acconut changes have been made.

Acconut commented 2 days ago

Thank you for the updates! I added some documentation and better handling for range requests and conditional requests, in particular regarding error responses. I couldn't push these changes to this PR because you didn't allow maintainers to modify your PR. So for now, I put them into a separate branch: https://github.com/tus/tusd/compare/main...s3-content-server

Feel free to review them. If you allow me to modify this PR, I can push them here. If not, we'll find another way to collaborate.

pcfreak30 commented 2 days ago

@Acconut sorry GitHub doesn't seem to be allowing me to give you access :/.