search

tuxd3v / ats

90 stars 12 forks source link

fix: Do not briefly spin up when setting 0 PWM #32

Closed asgeirrr closed 1 year ago

asgeirrr commented 1 year ago

Hello, first, let me express my thanks for this project, it made my setup of RockPro64 as a home NAS quite smooth.

The only problem was that I probably hit issue #28. Looks like whenever ATS wakes up and checks the temperature and derives the correct PWM for the temperature, makes sense. But I think there's a small bug that even if PWM == 0, it runs the procedure to spin up the fan only to set PWM == 0 once it's spinned up. The correct thing to do is probably skip the first branch and directly set PWM if equal to 0 (no fan warm-up necessary in this case).

I've tested this change quite thoughtfully on my machine and from my PoV, it works good. Let me know if I should do any changes to the PR.

tuxd3v commented 1 year ago

Thanks, it really make sense to only spin-up, if value is >0 :)

tuxd3v commented 1 year ago

I created a new commit following yours but I don't have now a RockPro64 to test, mine died :( Can you check if it works as expected?

Thanks in Advance tux