search

tvkitchen / appliances

A one stop shop for official TV Kitchen Appliances
GNU Lesser General Public License v3.0
3 stars 0 forks source link

Support Payload timestamps #76

Closed slifty closed 3 years ago

slifty commented 3 years ago

Task

Description

All appliances so far have ignored the concept of the Payload timestamp. This is because timestamps are hard to do elegantly, but it's time to get over it because they're important.

As a reminder, timestamps represent the actual moment in time that a given piece of data is associated with (as opposed to position which is how far into a given stream the data occurred).

There is a healthy rubber ducking session about whether appliances or the countertop should be responsible for timestamps, but at the very least it isn't wrong for appliances to populate Payload attributes so lets do it. Maybe later the countertop will make it unnecessary and we can remove it in certain appliances.

slifty commented 3 years ago

Payloads no longer have timestamps, so I'm closing this and instead creating a new issue about the much more simple concept of supporting payload origin (this may be renamed some day to originTimestamp but we're moving forward with origin for now.