search

tweag / cooked-validators

MIT License
39 stars 11 forks source link

Only generating collaterals when scripts are called #431

Closed mmontin closed 2 months ago

mmontin commented 4 months ago

This will close #420 .

This idea is that collateral are only ever required when the Cardano transaction has one or more script witnesses. However, we always provide collaterals even when only PKH are involved in a transaction. This PR aims at fixing just that.

The upside will be that transaction generation will be more accurate, and will not require extraneous outputs when it should not.

The downside will be that many tests rely on the current implementation and will need to be tweaked to work after this change, specifically in BalancingSpec.

mmontin commented 4 months ago

This branch is rebased and follows PR #430 and will be undrafted once this is merged. This dependency comes from the fact that we want to log when the user specifies collaterals which will not be used because no script is involved.