tweenjs / es6-tween

ES6 version of tween.js
MIT License
186 stars 34 forks source link

Initial attempt at ES6ifing #5

Closed salzhrani closed 8 years ago

salzhrani commented 8 years ago

Here is an unsolicited attempt to make an ES2015-tween. Hope you think it is useful, and would understand if it gets rejected. Included is a naive attempt at benchmarking the reformat, if it is any good it shows no negative impact of the reformating.

salzhrani commented 8 years ago

feedback @sole ?

sole commented 8 years ago

@salzhrani Sorry no feedback yet - I have been really busy with something else. Thanks for the attempt!

Feedback then! :-)

And then for the obvious:

salzhrani commented 8 years ago

I have updated the PR ... mainly splitting the library into separate modules, update the build and test scripts, use ESlint instead of JSHint.

For me the main issues with the current API are:

besides that the API seems suffice.

dalisoft commented 7 years ago

@sole @salzhrani Look at My PR. On npm using babel and webpack compiling minifed and source version takes less than 2-minutes. It's time to move to ES6 version. NOTE: It's starting, when we improve it together it will be better like emit instead of onUpdate, onStart or even new things.