Closed salzhrani closed 8 years ago
feedback @sole ?
@salzhrani Sorry no feedback yet - I have been really busy with something else. Thanks for the attempt!
Feedback then! :-)
tween.js
file is huge and unwieldy and there's no way of knowing what's going ondist/
compiled version as they always get out of dateAnd then for the obvious:
I have updated the PR ... mainly splitting the library into separate modules, update the build and test scripts, use ESlint instead of JSHint.
For me the main issues with the current API are:
Tween.update
unless there is a use case for that the user should not worry about animation frames and updating the tweenbesides that the API seems suffice.
@sole @salzhrani Look at My PR.
On npm
using babel
and webpack
compiling minifed and source version takes less than 2-minutes.
It's time to move to ES6 version.
NOTE: It's starting, when we improve it together it will be better like emit
instead of onUpdate, onStart
or even new things.
Here is an unsolicited attempt to make an ES2015-tween. Hope you think it is useful, and would understand if it gets rejected. Included is a naive attempt at benchmarking the reformat, if it is any good it shows no negative impact of the reformating.