twentyhq / twenty

Building a modern alternative to Salesforce, powered by the community.
https://twenty.com
Other
23.74k stars 2.45k forks source link

Correct style of "Change Color" in Notes block menu #6757

Closed Bonapara closed 1 month ago

Bonapara commented 3 months ago

Current Behavior

The "Change color" menu item, accessible via the 6 dots menu on the left side of the "Enter text or type '/' for commands" prompt, exhibits two issues:

Current Issue Screenshot

Desired Behavior

Desired Behavior Screenshot

harshit078 commented 3 months ago

Hi @Bonaparam, can I take this up ?

Bonapara commented 3 months ago

Sure @harshit078, thanks for contributing!

harshit078 commented 3 months ago

Hi @Bonapara, going through the issue I found out that BlockNote allows custom css using mantine but for chevron-right and color to secondary there are no such support. It seems that this component is built-in component in BlockNote and can't be changed. What are your views on it ?

Bonapara commented 3 months ago

Thanks for having a look @harshit078. Is it possible to hardcode the change? @lucasbordeau do you have any idea on this?

harshit078 commented 3 months ago

I did tried to hardcode and implement it but couldn't get the desired results. @lucasbordeau Is there something you could suggest or throw a light on ?

charlesBochet commented 3 months ago

@harshit078 I think it's on our side, looks like it's CustomSideMenuOptions

FelixMalfait commented 1 month ago

I just checked and this seems fairly difficult, it involves replacing https://github.com/TypeCellOS/BlockNote/blob/786bd8b310fa6483f6cdae28393d682296d296ae/packages/react/src/components/SideMenu/DragHandleMenu/DefaultItems/BlockColorsItem.tsx#L18 by our custom component which means more to maintain on our side and risk of conflicts as we update BlockNote. I think we should close this and maybe reconsider in 1 year but this is a high cost-to-impact task