twilight-project / quisquis-rust

1 stars 0 forks source link

Separate KeyGeneration and AccountGeneration #11

Open runnerelectrode opened 3 years ago

runnerelectrode commented 3 years ago

https://github.com/twilight-project/quisquis-rust/blob/78d9ddd85783b714dfd79f441b2f1531a8e347a4/src/accounts/accounts.rs#L36

Keypair generation must be an independent function. Precursor to #5

usmanshahid86 commented 3 years ago

Currently balance is represented as i64 and passed as the same to the internal methods. In my opinion, there should be a single entry point defined for u64 balance that converts it to a Scalar. Internal representation shall all be in scalars. This will make the code more neat and efficient.