search

twilio / authy-ruby

**Deprecated** Ruby library to access the authy API
MIT License
156 stars 47 forks source link

Allow Authy::API.register_user to take a :send_install_link_via_sms option #19

Closed treznick closed 8 years ago

treznick commented 8 years ago

Per the documentation in http://docs.authy.com/totp.html#totp-api

We are using the authy-devise gem for our production Rails app, and we want the option to not send users the install link via SMS when they register for authy.

Rather than fork both gems to pass in one flag to one request, we would love this to be merged!

We've attempted a spec, but given the existing structure of Authy::API.register_user, it doesn't appear that the client will fail when passed an option that it doesn't know how to deal with. Testing that the SMS sent doesn't have the link in question (ala an acceptance spec) seems outside of the scope of this PR.

Please let us know if there's anything else we can do to help! We love using this service and are happy to contribute toward its further open-source development.

Best, Tom Reznick Software Engineer Continuity

cc @alexwilkinson

treznick commented 8 years ago

fixed a typo in the spec. Please let me know if this PR needs anything else.

serargz commented 8 years ago

Thanks for the PR @treznick, we'll shortly merge it to master.

treznick commented 8 years ago

Thanks! FWIW the documentation defaults the :send_install_link_via_sms option to true, but it looks like my PR sets this as false by default. I'll update this

treznick commented 8 years ago

@serargz Anything you all need on my end for this to get merged? Happy to help.

treznick commented 8 years ago

@serargz pinging again to see if this is ready to merge. Again, happy to make any changes you folks require. Feel free to reach out. Thanks!

serargz commented 8 years ago

@treznick I'm catching up with reviewing and approving pull requests, sorry for the long delay. Will get back to you soon.

treznick commented 8 years ago

no worries @serargz. Thanks for all the work maintaining this!

serargz commented 8 years ago

Thank you @treznick, PR merged.

treznick commented 8 years ago

Thanks!

On Fri, Jul 15, 2016 at 5:09 PM, Sergio notifications@github.com wrote:

Thank you @treznick https://github.com/treznick, PR merged.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/authy/authy-ruby/pull/19#issuecomment-233070645, or mute the thread https://github.com/notifications/unsubscribe-auth/AAlwA9lWlDQPVWaRZRwpLHpZxEn1dB-Fks5qV_cAgaJpZM4GskzT .