search

twilio / authy-ruby

**Deprecated** Ruby library to access the authy API
MIT License
156 stars 47 forks source link

Automatic E164 Support #44

Closed gbudiman closed 4 years ago

philnash commented 5 years ago

I'm torn over this now. I agree that it's useful to make it easier for users of this gem to provide numbers in the format they have (or can get) them.

However, adding the phony for effectively one line of code seems overkill for those who don't need to use it.

You could simply use phony outside of the call to Authy.register_user to split the number up. In fact, if you did that it would give you the choice of dependency to use between choices like phony, telephone_number or phonelib.

Perhaps the real solution is to document the various ways you could take an e164 formatted number and produce a country code and a national number.

robinske commented 4 years ago

Hey @gbudiman - going to close this out since we haven't heard anything recently. Let us know if you have any other questions, issues, or contributions.