Expose event information in on_save_position

twingly / ecco

:dolphin: MySQL replication binlog parser in JRuby

7 stars 2 forks source link

Expose event information in on_save_position #24

Closed dentarg closed 8 years ago

dentarg commented 8 years ago

This first commit is a somewhat quick and naive change, to have something to discuss.

Related to #23.

dentarg commented 8 years ago

Now we have a of bit duplication between RowEventListener and SaveEventListener (the mapping of the name of some event types). One idea is to make an helper class for this, with row_type_to_string and the different lists (ROW_EVENTS, SAVE_EVENTS), that the listeners can use. WDYT?

jage commented 8 years ago

I think this will work. Haven't looked at the specs, but I think the implementation is good.

dentarg commented 8 years ago

Let's release this as 0.7.0, right?

jage commented 8 years ago

Let's release this as 0.7.0, right?

Yes.